PhpSpreadsheet/tests/PhpSpreadsheetTests/Reader
oleibman 497a934374
Fix for 3 Issues Involving ReadXlsx and NamedRange (#1742)
* Fix for 3 Issues Involving ReadXlsx and NamedRange

Issues #1686 and #1723, which provide sample spreadsheets, are probably
solved by this ticket. Issue #1730 is also probably solved, but I have
no way to verify.

There are two problems with how PhpSpreadsheet is handling things now.
Although the first problem is much less severe, and isn't really a factor
in the issues named above, it is helpful to get it out of the way first.
If you define a named range in Excel, and then delete the sheet where
the range exists, Excel saves the range as #REF!. If there is a cell which
references the range, it will similarly have the value #REF! when you open
the Excel file.
Currently, PhpSpreadsheet discards the #REF! definition, so a cell which
references the range will appear as #NAME? rather than #REF!.
This PR changes the behavior so that PhpSpreadsheet retains the #REF!
definition, and cells which reference it will appear as #REF!.

The second problem is the more severe, and is, I believe, responsible
for the 3 issues identified above.
If you define a named range and the sheet on which the range is defined
does not exist at the time, Excel will save the range as something like:

'[1]Unknown Sheet'!$A$1

If a cell references such a range, Excel will again display #REF!.
PhpSpreadsheet currently throws an Exception when it encounters
such a definition while reading the file. This PR changes
the behavior so that PhpSpreadsheet saves the definition as #REF!,
and cells which reference it will behave similarly.

For the record, I will note that Excel does not magically recalculate when a
missing sheet is subsequently added, despite the fact that the reference
might now become resolvable. PhpSpreadsheet behaves likewise.

* Remove Dead Code in Test

Identified it after push but before merge.
2020-12-10 18:08:10 +01:00
..
Gnumeric Stricter visibility 2020-07-19 12:30:31 +09:00
Html PSR12 code style 2020-07-26 14:13:11 +09:00
Ods Improve Coverage for ODS Reader (#1545) 2020-07-26 12:40:49 +09:00
Security fixed php8 deprecation warning for libxml_disable_entity_loader() (#1625) 2020-10-08 15:02:14 +02:00
Xls Stricter visibility 2020-07-19 12:30:31 +09:00
Xlsx Fix for 3 Issues Involving ReadXlsx and NamedRange (#1742) 2020-12-10 18:08:10 +01:00
Xml Drop Travis 2020-11-26 11:10:52 +09:00
CondNumFmtTest.php Update PHP-CS-Fixer rules 2020-05-18 13:49:57 +09:00
CsvContiguousFilter.php Update PHP-CS-Fixer rules 2020-05-18 13:49:57 +09:00
CsvContiguousTest.php Update PHP-CS-Fixer rules 2020-05-18 13:49:57 +09:00
CsvTest.php Improving Coverage for Excel2003 XML Reader (#1557) 2020-10-11 13:26:56 +02:00
OddColumnReadFilter.php Fix column names if read filter calls in XLSX reader skip columns 2018-12-10 20:00:26 +11:00
SlkTest.php Improve Coverage for Sylk (#1514) 2020-06-19 20:35:44 +02:00
XlsTest.php Fix for #1505 (#1525) 2020-06-19 21:01:18 +02:00
Xlsx2Test.php Testing - Delete Temp Files When No Longer Needed (#1488) 2020-05-24 20:03:07 +09:00
XlsxTest.php Testing - Delete Temp Files When No Longer Needed (#1488) 2020-05-24 20:03:07 +09:00