alex/PhpSpreadsheet
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
73379cdfb1
PhpSpreadsheet/samples/templates
History
oleibman 73379cdfb1
Improve Coverage for Gnumeric (#1517) 
* Improve Coverage for Gnumeric

I believe that both BaseReader and Gnumeric Reader are now 100% covered.

My goal was to use PhpSpreadsheet to load the test file,
save it as Xlsx, and visually compare the two, then add a test
loaded with assertions. Results were generally pretty good,
but there were no tests with assertions. I added a few cells
to exercise some previously uncovered code. Code was extensively
refactored; logic changes are noted below.

Code allowed for specifying document properties in an old format.
I considered removing that, but I found the original spec at
http://www.jfree.org/jworkbook/download/gnumeric-xml.pdf
This allowed me to create an old file, which was not handled
correctly because of namespace differences. The code was corrected
to allow for this difference.

Added support for textRotation.

Mapping of fill types was not correct.

* PHP7.2 Error

One assertion failed under PHP7.2. Apparently there was some change in
the handling of SimpleXMLElement between 7.2 and 7.3. Casting to string
before use eliminates the problem.

* Scrutinizer Recommendations

All minor, solved (hopefully) mostly by casts.

* One Last Scrutinizer Fix

... I hope.
2020-06-19 20:34:02 +02:00
..
26template.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
27template.xls Could not read old PNG with latest libpng on Ubuntu 17.04 2017-05-26 12:47:14 +02:00
28iterators.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
30template.xls Reorganize code samples 2016-09-01 01:17:13 +09:00
31docproperties.xls Reorganize code samples 2016-09-01 01:17:13 +09:00
31docproperties.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32chartreadwrite.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32complexChartreadwrite.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteAreaChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteAreaChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteAreaChart3.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteAreaChart3D1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteAreaPercentageChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteAreaPercentageChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteAreaPercentageChart3D1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteAreaStackedChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteAreaStackedChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteAreaStackedChart3D1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteBarChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteBarChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteBarChart3.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteBarChart3D1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteBarPercentageChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteBarPercentageChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteBarPercentageChart3D1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteBarStackedChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteBarStackedChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteBarStackedChart3D1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteBubbleChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteBubbleChart3D1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteChartWithImages1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteColumnChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteColumnChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteColumnChart3.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteColumnChart3D1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteColumnChart4.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteColumnPercentageChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteColumnPercentageChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteColumnPercentageChart3D1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteColumnStackedChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteColumnStackedChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteColumnStackedChart3D1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteDonutChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteDonutChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteDonutChart3.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteDonutChart4.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteDonutChartExploded1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteDonutChartMultiseries1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteLineChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteLineChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteLineChart3.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteLineChart3D1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteLineChartNoPointMarkers1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteLinePercentageChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteLinePercentageChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteLineStackedChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteLineStackedChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwritePieChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwritePieChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwritePieChart3.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwritePieChart3D1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwritePieChart4.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwritePieChartExploded1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwritePieChartExploded3D1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteRadarChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteRadarChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteRadarChart3.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteScatterChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteScatterChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteScatterChart3.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteScatterChart4.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteScatterChart5.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteStockChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteStockChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteStockChart3.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteStockChart4.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteSurfaceChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteSurfaceChart2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteSurfaceChart3.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
32readwriteSurfaceChart4.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
36writeLineChart1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
43mergeBook1.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
43mergeBook2.xlsx Reorganize code samples 2016-09-01 01:17:13 +09:00
46readHtml.html HTML reader supports text and background color from inline CSS, for td and th element 2017-06-23 11:28:17 +02:00
chartSpreadsheet.php Update PHP-CS-Fixer rules 2020-05-18 13:49:57 +09:00
Excel2003XMLTest.xml Prefer https:// URLs when available in docs & comments 2018-10-28 13:55:00 +11:00
GnumericTest.gnumeric Improve Coverage for Gnumeric (#1517) 2020-06-19 20:34:02 +02:00
largeSpreadsheet.php Update to PHP-CS-Fixer 2.10 2018-01-28 15:59:38 +09:00
old.gnumeric Improve Coverage for Gnumeric (#1517) 2020-06-19 20:34:02 +02:00
OOCalcTest.ods Clean up very obsolete links 2017-12-30 19:07:22 +09:00
sampleSpreadsheet.php Update PHP-CS-Fixer rules 2020-05-18 13:49:57 +09:00
SylkTest.slk Reorganize code samples 2016-09-01 01:17:13 +09:00