PhpSpreadsheet/tests/PhpSpreadsheetTests
oleibman afd070a756 Handle ConditionalStyle NumberFormat When Reading Xlsx File (#1296)
* Handle ConditionalStyle NumberFormat When Reading Xlsx File

ReadStyle in Reader/Xlsx/Styles.php expects numberFormat to be a string.
However, when reading conditional style in Xlsx file, NumberFormat
   is actually a SimpleXMLElement, so is not handled correctly.
While testing this change, it turned out that reader always expects
   that there is a "SharedString" portion of the XML, which is not
   true for spreadsheets with no string data, which causes a
   run-time message.
Likewise, when conditional number format is not one of the built-in
   formats, a run-time message is issued because 'isset' is used
   to determine existence rather than 'array_key_exists'.
The new workbook added to the testing data demonstrates both those
   problems (prior to the code changes).

* Move Comment to Resolve Conflict

Github reports conflict involving placement of one comment statement.

* Respond to Scrutinizer Style Suggestion

Change detection for empty SimpleXMLElement.
2020-01-04 00:10:41 +01:00
..
Calculation Do not confuse defined names and cell refs 2019-11-30 16:10:43 +01:00
Cell Addition cell datatype tests (#1303) 2020-01-03 23:44:38 +01:00
Chart Custom color for pie and donut charts 2018-12-10 18:43:55 +11:00
Collection - Create unit test (#944) 2019-04-15 21:39:11 +02:00
Custom Test fixes for PHP 7.4 stricter behaviour 2019-09-20 16:22:08 -07:00
Functional CS Fixes (#962) 2019-04-15 22:49:51 +02:00
Helper Upgrade to phpunit 7.5 2019-07-24 23:45:43 -07:00
Reader Handle ConditionalStyle NumberFormat When Reading Xlsx File (#1296) 2020-01-04 00:10:41 +01:00
Shared Upgrade to phpunit 7.5 2019-07-24 23:45:43 -07:00
Style Chained operations on cell ranges involving borders are now possible 2018-07-15 12:19:54 +09:00
Worksheet Add test for PhpOffice\PhpSpreadsheet\Worksheet\ColumnDimension 2019-11-17 21:19:50 +01:00
Writer Modify XLSX RW to keep decimal for floats with a zero decimal part 2019-11-30 16:15:48 +01:00
IOFactoryTest.php Add test for IOFactory::load 2019-11-17 18:39:38 +01:00
ReferenceHelperTest.php Add ReferenceHelper::cellSort and ReferenceHelper::cellReverseSort tests 2019-11-17 20:50:55 +01:00
SettingsTest.php Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase (#271) 2017-11-09 00:48:01 +09:00
SpreadsheetTest.php Cover getSheetByName() with tests for name with quote and spaces 2019-07-27 22:46:41 -07:00