5 Commits

Author	SHA1	Message	Date
oleibman	1c6dd8923e	Handle Error in Formula Processing Better for Xls (#1267) ... * Handle Error in Formula Processing Better for Xls When there is an error writing a formula to an Xls file, which seems to happen when a defined name is part of a formula, the cell is currently left blank. A better result would be to write the calculated value of the formula. * Making Changes Suggested in Review Per comment from Mark Baker: 1. Made return codes from writeFormula into constants. 2. Skipped redundant call to getCellValue when possible. 3. Added support for bool type, adding additional tests for bool and string. Per comment from PowerKiki: 1. Used standardized convention for assigning file name in test. Since before this change, save would throw Exception, I kept the unlink for the file in tearDown.	2020-01-04 18:34:21 +01:00
Gabriel Caruso	aed27a0bed	Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase (#271) ... Use the `PHPUnit\Framework\TestCase` notation instead of `PHPUnit_Framework_TestCase` while extending our TestCases. This will help us migrate to PHPUnit 6, that [no longer support snake case class names](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.0.md#changed-1).	2017-11-09 00:48:01 +09:00
mosa	ee700f7c7d	change array_push() to $array[] (#254) ... http://php.net/manual/en/function.array-push.php#refsect1-function.array-push-description > Note: If you use array_push() to add one element to the array it's better to use $array[] = because in that way there is no overhead of calling a function.	2017-10-19 11:07:31 +09:00
Adrien Crivelli	aef4d711f5	Use `self::assert*()` instead of `$this->assert*()` ... Because even if it doesn't make a difference in practice, it is technically more correct to call static methods statically. It also better advertise that those methods can be used from any context.	2017-09-22 14:22:44 +09:00
all-lala	81c1b14048	Re-use original palette color when possible ... This is to prevent color changing when copy/pasting xls files written by PhpSpreadsheet to another file. Closes #218	2017-09-11 14:28:49 +09:00