From fe121e8f7aee43182015defc36900a69eec4eb0c Mon Sep 17 00:00:00 2001
From: Mark Baker <mark@lange.demon.co.uk>
Date: Sat, 25 Jul 2020 21:58:08 +0200
Subject: [PATCH] Additional statistical unit tests for non-happy path (#1594)

* Additional statistical unit tests for non-happy path
---
 .../Functions/Statistical/CorrelTest.php      |  4 ++-
 .../Functions/Statistical/KurtTest.php        | 25 +++++++++++++++++++
 .../data/Calculation/Statistical/BETADIST.php |  8 ++++++
 .../data/Calculation/Statistical/BETAINV.php  |  8 ++++++
 .../Calculation/Statistical/BINOMDIST.php     | 12 +++++++++
 .../data/Calculation/Statistical/CHIDIST.php  |  4 +++
 tests/data/Calculation/Statistical/CHIINV.php |  4 +++
 .../Calculation/Statistical/CONFIDENCE.php    | 12 +++++++++
 tests/data/Calculation/Statistical/CORREL.php | 15 +++++++++++
 .../Calculation/Statistical/EXPONDIST.php     |  8 ++++++
 tests/data/Calculation/Statistical/FISHER.php |  8 ++++++
 .../Calculation/Statistical/FISHERINV.php     |  4 +++
 .../Calculation/Statistical/GAMMADIST.php     |  8 ++++++
 .../data/Calculation/Statistical/GAMMAINV.php |  8 ++++++
 .../data/Calculation/Statistical/GAMMALN.php  |  8 ++++++
 tests/data/Calculation/Statistical/KURT.php   | 12 +++++++++
 tests/data/Calculation/Statistical/STEYX.php  | 10 ++++++++
 17 files changed, 157 insertions(+), 1 deletion(-)
 create mode 100644 tests/PhpSpreadsheetTests/Calculation/Functions/Statistical/KurtTest.php
 create mode 100644 tests/data/Calculation/Statistical/KURT.php

diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Statistical/CorrelTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Statistical/CorrelTest.php
index 52f773bc..960a4cfd 100644
--- a/tests/PhpSpreadsheetTests/Calculation/Functions/Statistical/CorrelTest.php
+++ b/tests/PhpSpreadsheetTests/Calculation/Functions/Statistical/CorrelTest.php
@@ -17,8 +17,10 @@ class CorrelTest extends TestCase
      * @dataProvider providerCORREL
      *
      * @param mixed $expectedResult
+     * @param mixed $xargs
+     * @param mixed $yargs
      */
-    public function testCORREL($expectedResult, array $xargs, array $yargs): void
+    public function testCORREL($expectedResult, $xargs, $yargs): void
     {
         $result = Statistical::CORREL($xargs, $yargs);
         self::assertEqualsWithDelta($expectedResult, $result, 1E-12);
diff --git a/tests/PhpSpreadsheetTests/Calculation/Functions/Statistical/KurtTest.php b/tests/PhpSpreadsheetTests/Calculation/Functions/Statistical/KurtTest.php
new file mode 100644
index 00000000..b62aa026
--- /dev/null
+++ b/tests/PhpSpreadsheetTests/Calculation/Functions/Statistical/KurtTest.php
@@ -0,0 +1,25 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheetTests\Calculation\Functions\Statistical;
+
+use PhpOffice\PhpSpreadsheet\Calculation\Statistical;
+use PHPUnit\Framework\TestCase;
+
+class KurtTest extends TestCase
+{
+    /**
+     * @dataProvider providerKURT
+     *
+     * @param mixed $expectedResult
+     */
+    public function testKURT($expectedResult, ...$values): void
+    {
+        $result = Statistical::KURT(...$values);
+        self::assertEqualsWithDelta($expectedResult, $result, 1E-12);
+    }
+
+    public function providerKURT()
+    {
+        return require 'tests/data/Calculation/Statistical/KURT.php';
+    }
+}
diff --git a/tests/data/Calculation/Statistical/BETADIST.php b/tests/data/Calculation/Statistical/BETADIST.php
index b89de805..f489429c 100644
--- a/tests/data/Calculation/Statistical/BETADIST.php
+++ b/tests/data/Calculation/Statistical/BETADIST.php
@@ -21,4 +21,12 @@ return [
         0.685470581054,
         2, 8, 10, 1, 3,
     ],
+    [
+        '#VALUE!',
+        2, 'NAN', 10, 1, 3,
+    ],
+    [
+        '#NUM!',
+        2, -8, 10, 1, 3,
+    ],
 ];
diff --git a/tests/data/Calculation/Statistical/BETAINV.php b/tests/data/Calculation/Statistical/BETAINV.php
index 5406c0d5..d62c1c35 100644
--- a/tests/data/Calculation/Statistical/BETAINV.php
+++ b/tests/data/Calculation/Statistical/BETAINV.php
@@ -21,4 +21,12 @@ return [
         0.303225844664,
         0.2, 4, 5, 0, 1,
     ],
+    [
+        '#VALUE!',
+        0.2, 'NAN', 5, 0, 1,
+    ],
+    [
+        '#NUM!',
+        0.2, -4, 5, 0, 1,
+    ],
 ];
diff --git a/tests/data/Calculation/Statistical/BINOMDIST.php b/tests/data/Calculation/Statistical/BINOMDIST.php
index 93eacaf6..47e8a3f3 100644
--- a/tests/data/Calculation/Statistical/BINOMDIST.php
+++ b/tests/data/Calculation/Statistical/BINOMDIST.php
@@ -45,4 +45,16 @@ return [
         0.999105034804,
         65, 100, 0.5, true,
     ],
+    [
+        '#VALUE!',
+        'NAN', 100, 0.5, true,
+    ],
+    [
+        '#NUM!',
+        -5, 100, 0.5, true,
+    ],
+    [
+        '#NUM!',
+        5, 100, 1.5, true,
+    ],
 ];
diff --git a/tests/data/Calculation/Statistical/CHIDIST.php b/tests/data/Calculation/Statistical/CHIDIST.php
index a83256c9..4093b991 100644
--- a/tests/data/Calculation/Statistical/CHIDIST.php
+++ b/tests/data/Calculation/Statistical/CHIDIST.php
@@ -33,4 +33,8 @@ return [
         0.046011705689,
         8, 3,
     ],
+    [
+        '#VALUE!',
+        'NAN', 3,
+    ],
 ];
diff --git a/tests/data/Calculation/Statistical/CHIINV.php b/tests/data/Calculation/Statistical/CHIINV.php
index e1c7199e..2384cda6 100644
--- a/tests/data/Calculation/Statistical/CHIINV.php
+++ b/tests/data/Calculation/Statistical/CHIINV.php
@@ -33,4 +33,8 @@ return [
         4.108344935632,
         0.25, 3,
     ],
+    [
+        '#VALUE!',
+        0.25, 'NAN',
+    ],
 ];
diff --git a/tests/data/Calculation/Statistical/CONFIDENCE.php b/tests/data/Calculation/Statistical/CONFIDENCE.php
index 484eef27..8fd68abc 100644
--- a/tests/data/Calculation/Statistical/CONFIDENCE.php
+++ b/tests/data/Calculation/Statistical/CONFIDENCE.php
@@ -13,4 +13,16 @@ return [
         0.013719747903,
         0.05, 0.07, 100,
     ],
+    [
+        '#VALUE!',
+        'NAN', 0.07, 100,
+    ],
+    [
+        '#NUM!',
+        1.05, 0.07, 100,
+    ],
+    [
+        '#NUM!',
+        0.05, -0.07, 100,
+    ],
 ];
diff --git a/tests/data/Calculation/Statistical/CORREL.php b/tests/data/Calculation/Statistical/CORREL.php
index de03a480..409abbd6 100644
--- a/tests/data/Calculation/Statistical/CORREL.php
+++ b/tests/data/Calculation/Statistical/CORREL.php
@@ -11,4 +11,19 @@ return [
         [2, 10, 7, 17, 14, 16, 8, 12, 11, 15, 18, 3, 4, 1, 6, 5, 13, 19, 20, 9],
         [22.9, 45.78, 33.49, 49.77, 40.94, 36.18, 21.05, 50.57, 31.32, 53.76, 55.66, 27.61, 11.15, 10.11, 37.9, 31.08, 45.48, 63.83, 63.6, 27.01],
     ],
+    [
+        '#VALUE!',
+        3,
+        9,
+    ],
+    [
+        '#N/A',
+        [],
+        [],
+    ],
+    [
+        '#DIV/0!',
+        [3],
+        [9],
+    ],
 ];
diff --git a/tests/data/Calculation/Statistical/EXPONDIST.php b/tests/data/Calculation/Statistical/EXPONDIST.php
index 546668fd..df150e19 100644
--- a/tests/data/Calculation/Statistical/EXPONDIST.php
+++ b/tests/data/Calculation/Statistical/EXPONDIST.php
@@ -9,4 +9,12 @@ return [
         0.393469340287,
         0.5, 1, true,
     ],
+    [
+        '#VALUE!',
+        0.5, 'NAN', true,
+    ],
+    [
+        '#NUM!',
+        -0.5, 1, true,
+    ],
 ];
diff --git a/tests/data/Calculation/Statistical/FISHER.php b/tests/data/Calculation/Statistical/FISHER.php
index fc35acba..12909012 100644
--- a/tests/data/Calculation/Statistical/FISHER.php
+++ b/tests/data/Calculation/Statistical/FISHER.php
@@ -13,4 +13,12 @@ return [
         1.098612288668,
         0.8,
     ],
+    [
+        '#VALUE!',
+        'NAN',
+    ],
+    [
+        '#NUM!',
+        -2,
+    ],
 ];
diff --git a/tests/data/Calculation/Statistical/FISHERINV.php b/tests/data/Calculation/Statistical/FISHERINV.php
index 6e5bf20a..b79fd4f8 100644
--- a/tests/data/Calculation/Statistical/FISHERINV.php
+++ b/tests/data/Calculation/Statistical/FISHERINV.php
@@ -17,4 +17,8 @@ return [
         0.992631520201,
         2.8,
     ],
+    [
+        '#VALUE!',
+        'NAN',
+    ],
 ];
diff --git a/tests/data/Calculation/Statistical/GAMMADIST.php b/tests/data/Calculation/Statistical/GAMMADIST.php
index f993fb5d..dfc93c63 100644
--- a/tests/data/Calculation/Statistical/GAMMADIST.php
+++ b/tests/data/Calculation/Statistical/GAMMADIST.php
@@ -9,4 +9,12 @@ return [
         0.576809918873,
         6, 3, 2, true,
     ],
+    [
+        '#VALUE!',
+        6, 'NAN', 2, true,
+    ],
+    [
+        '#NUM!',
+        -6, 3, 2, true,
+    ],
 ];
diff --git a/tests/data/Calculation/Statistical/GAMMAINV.php b/tests/data/Calculation/Statistical/GAMMAINV.php
index 5a2b7153..64869092 100644
--- a/tests/data/Calculation/Statistical/GAMMAINV.php
+++ b/tests/data/Calculation/Statistical/GAMMAINV.php
@@ -5,4 +5,12 @@ return [
         5.348120627447,
         0.5, 3, 2,
     ],
+    [
+        '#VALUE!',
+        'NAN', 3, 2,
+    ],
+    [
+        '#NUM!',
+        -0.5, 3, 2,
+    ],
 ];
diff --git a/tests/data/Calculation/Statistical/GAMMALN.php b/tests/data/Calculation/Statistical/GAMMALN.php
index 146b2f95..783f0afd 100644
--- a/tests/data/Calculation/Statistical/GAMMALN.php
+++ b/tests/data/Calculation/Statistical/GAMMALN.php
@@ -5,4 +5,12 @@ return [
         2.453736570842,
         4.5,
     ],
+    [
+        '#VALUE!',
+        'NAN',
+    ],
+    [
+        '#NUM!',
+        -4.5,
+    ],
 ];
diff --git a/tests/data/Calculation/Statistical/KURT.php b/tests/data/Calculation/Statistical/KURT.php
new file mode 100644
index 00000000..cae7dbc8
--- /dev/null
+++ b/tests/data/Calculation/Statistical/KURT.php
@@ -0,0 +1,12 @@
+<?php
+
+return[
+    [
+        -0.1517996372084,
+        [3, 4, 5, 2, 3, 4, 5, 6, 4, 7],
+    ],
+    [
+        0.532657874050135,
+        [4, 5, 4, 4, 4, 4, 4, 2, 3, 5, 5, 3],
+    ],
+];
diff --git a/tests/data/Calculation/Statistical/STEYX.php b/tests/data/Calculation/Statistical/STEYX.php
index dc0b04a4..a87ff592 100644
--- a/tests/data/Calculation/Statistical/STEYX.php
+++ b/tests/data/Calculation/Statistical/STEYX.php
@@ -11,4 +11,14 @@ return [
         [3, 7.9, 8, 9.2, 12, 10.5, 15, 15.5, 17],
         [1, 2, 3, 4, 4.5, 5, 6, 7, 8],
     ],
+    [
+        '#N/A',
+        [],
+        [],
+    ],
+    [
+        '#DIV/0!',
+        [2],
+        [1],
+    ],
 ];