alex
/
PhpSpreadsheet
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Basic unit test and fix for loading data validations from xlsx file (#1063)

This commit is contained in:
Mark Baker 2019-07-08 19:55:14 +02:00 committed by GitHub
parent d4eab49815
commit d8047b071b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/PhpSpreadsheet/Reader/Xlsx/DataValidations.php
View File

@ -19,7 +19,7 @@ class DataValidations
public function load()
{
foreach ($this->worksheetXml->dataValidation as $dataValidation) {
foreach ($this->worksheetXml->dataValidations->dataValidation as $dataValidation) {
// Uppercase coordinate
$range = strtoupper($dataValidation['sqref']);
$rangeSet = explode(' ', $range);

11
tests/PhpSpreadsheetTests/Reader/XlsxTest.php
View File

@ -158,6 +158,17 @@ class XlsxTest extends TestCase
$this->assertInstanceOf(Style::class, $conditionalRule->getStyle());
}
public function testLoadXlsxDataValidation()
{
$filename = './data/Reader/XLSX/dataValidationTest.xlsx';
$reader = new Xlsx();
$spreadsheet = $reader->load($filename);
$worksheet = $spreadsheet->getActiveSheet();
$this->assertTrue($worksheet->getCell('B3')->hasDataValidation());
}
/**
* Test load Xlsx file without cell reference.
*

BIN
tests/data/Reader/XLSX/dataValidationTest.xlsx Normal file
View File

Binary file not shown.