alex
/
PhpSpreadsheet
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

removeColumn doesn't remove all cells 

removeColumn doesn't remove all cells, because CacheBase::deleteCacheData only unsets cell data if they are objects.
But cached cell data could be arrays.
I moved the unset from inside the if block (line 150 ff) to after the if block.
This commit is contained in:
josch1710 2016-08-23 17:31:28 +02:00 committed by Adrien Crivelli
parent 3b4f54722f
commit c1f5bdba5d
No known key found for this signature in database
GPG Key ID: B182FD79DC6DE92E
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/PhpSpreadsheet/CachedObjectStorage/CacheBase.php
View File

@ -147,8 +147,8 @@ abstract class CacheBase
if (is_object($this->cellCache[$pCoord])) { if (is_object($this->cellCache[$pCoord])) {
$this->cellCache[$pCoord]->detach(); $this->cellCache[$pCoord]->detach();
unset($this->cellCache[$pCoord]);
} }
unset($this->cellCache[$pCoord]);
$this->currentCellIsDirty = false; $this->currentCellIsDirty = false;
} }