From 7d13b6de2ea0c1df8b0c9c1bf6e165e122ba63c1 Mon Sep 17 00:00:00 2001 From: Mark Baker Date: Sat, 4 Aug 2012 16:08:28 +0100 Subject: [PATCH] Bugfix: Work item 18377 - Chart Title compatibility on Excel 2007 --- Classes/PHPExcel/Writer/Excel2007/Chart.php | 4 ++-- Classes/PHPExcel/Writer/Excel2007/StringTable.php | 2 +- changelog.txt | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Classes/PHPExcel/Writer/Excel2007/Chart.php b/Classes/PHPExcel/Writer/Excel2007/Chart.php index 7316d8dc..4b0376cb 100644 --- a/Classes/PHPExcel/Writer/Excel2007/Chart.php +++ b/Classes/PHPExcel/Writer/Excel2007/Chart.php @@ -444,7 +444,7 @@ class PHPExcel_Writer_Excel2007_Chart extends PHPExcel_Writer_Excel2007_WriterPa if (is_array($caption)) $caption = $caption[0]; $objWriter->startElement('a:t'); - $objWriter->writeAttribute('xml:space', 'preserve'); +// $objWriter->writeAttribute('xml:space', 'preserve'); $objWriter->writeRawData(PHPExcel_Shared_String::ControlCharacterPHP2OOXML( $caption )); $objWriter->endElement(); @@ -570,7 +570,7 @@ class PHPExcel_Writer_Excel2007_Chart extends PHPExcel_Writer_Excel2007_WriterPa if (is_array($caption)) $caption = $caption[0]; $objWriter->startElement('a:t'); - $objWriter->writeAttribute('xml:space', 'preserve'); +// $objWriter->writeAttribute('xml:space', 'preserve'); $objWriter->writeRawData(PHPExcel_Shared_String::ControlCharacterPHP2OOXML( $caption )); $objWriter->endElement(); diff --git a/Classes/PHPExcel/Writer/Excel2007/StringTable.php b/Classes/PHPExcel/Writer/Excel2007/StringTable.php index 5399ef94..ee77be4f 100644 --- a/Classes/PHPExcel/Writer/Excel2007/StringTable.php +++ b/Classes/PHPExcel/Writer/Excel2007/StringTable.php @@ -286,7 +286,7 @@ class PHPExcel_Writer_Excel2007_StringTable extends PHPExcel_Writer_Excel2007_Wr // t $objWriter->startElement($prefix.'t'); - $objWriter->writeAttribute('xml:space', 'preserve'); +// $objWriter->writeAttribute('xml:space', 'preserve'); // Excel2010 accepts, Excel2007 complains $objWriter->writeRawData(PHPExcel_Shared_String::ControlCharacterPHP2OOXML( $element->getText() )); $objWriter->endElement(); diff --git a/changelog.txt b/changelog.txt index 6d0c51bc..46765c03 100644 --- a/changelog.txt +++ b/changelog.txt @@ -93,6 +93,7 @@ Fixed in develop branch: - Bugfix: (MBaker) Work item 18370 - Error loading xlsx file with column breaks - Bugfix: (MBaker) OOCalc Reader now handles percentage and currency data types - Bugfix: (MBaker) OOCalc Reader modified to process number-rows-repeated +- Bugfix: (MBaker) Work item 18377 - Chart Title compatibility on Excel 2007 2012-05-19 (v1.7.7):