From 9ba96efc972b531407fe8767b3e3dd9b6b6aeba0 Mon Sep 17 00:00:00 2001 From: MarkBaker Date: Thu, 30 May 2019 12:11:49 +0200 Subject: [PATCH] Still test against 5.6, but with allowed failures, and skip tests explicitly for features that require PHP >= 7.0.0 --- CHANGELOG.md | 2 -- tests/PhpSpreadsheetTests/Reader/XlsxTest.php | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b63109be..517bfb03 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,8 +7,6 @@ and this project adheres to [Semantic Versioning](https://semver.org). ## [Unreleased] -- **Minimum version of PHP for the next release is now 7.0.0** - ### Added - Added support for the SWITCH function - [Issue #963](https://github.com/PHPOffice/PhpSpreadsheet/issues/963) and [PR #983](https://github.com/PHPOffice/PhpSpreadsheet/pull/983) diff --git a/tests/PhpSpreadsheetTests/Reader/XlsxTest.php b/tests/PhpSpreadsheetTests/Reader/XlsxTest.php index 3653c3d1..733f3689 100644 --- a/tests/PhpSpreadsheetTests/Reader/XlsxTest.php +++ b/tests/PhpSpreadsheetTests/Reader/XlsxTest.php @@ -39,6 +39,9 @@ class XlsxTest extends TestCase */ public function testLoadXlsxWithDoubleAttrDrawing() { + if (version_compare(PHP_VERSION, '7.0.0', '<')) { + $this->markTestSkipped('Only handled in PHP version >= 7.0.0'); + } $filename = './data/Reader/XLSX/double_attr_drawing.xlsx'; $reader = new Xlsx(); $reader->load($filename);