alex
/
PhpSpreadsheet
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

style fixes

This commit is contained in:
MarkBaker 2017-11-26 23:18:11 +00:00
parent 19fd27811d
commit 90366f9dd1
2 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/PhpSpreadsheet/Calculation/MathTrig.php
View File

@ -312,14 +312,8 @@ class MathTrig
return Functions::VALUE(); return Functions::VALUE();
} }
public static function evaluateGCD($a, $b) { public static function evaluateGCD($a, $b)
// As we're just working with two values, we can use the recursive Euclidian method {
// If we were working with more than two values, we need to extend as
// gcd(gcd(a, b), c)
// to encompass all the values we need to evaluate
// The method we're using is limited to integers, if we wanted to support floats as well
// then we'd need something like:
// return $b > .000000000001 ? gcd($b, fmod($a, $b)) : $a;
return $b ? self::evaluateGCD($b, $a % $b) : $a; return $b ? self::evaluateGCD($b, $a % $b) : $a;
} }