alex
/
PhpSpreadsheet
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fixes for continue inside switch statement (#660) 

This a bugfix for php 7.3 related errors where using continue inside a switch raises a PHP warning. Either use continue 2 or break. Previously continue behaves like break but the intended usage is to continue the for loop instead.
This commit is contained in:
Roland Eigelsreiter 2018-09-29 18:11:24 +02:00 committed by Adrien Crivelli
parent 01501b6ff2
commit 9022c39dd8
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/PhpSpreadsheet/Reader/Xls.php
View File

@ -1127,7 +1127,7 @@ class Xls extends BaseReader
// TODO: Why is there no BSE Index? Is this a new Office Version? Password protected field? // TODO: Why is there no BSE Index? Is this a new Office Version? Password protected field?
// More likely : a uncompatible picture // More likely : a uncompatible picture
if (!$BSEindex) { if (!$BSEindex) {
continue; continue 2;
} }
$BSECollection = $escherWorkbook->getDggContainer()->getBstoreContainer()->getBSECollection(); $BSECollection = $escherWorkbook->getDggContainer()->getBstoreContainer()->getBSECollection();

2
src/PhpSpreadsheet/Shared/OLE.php
View File

@ -320,7 +320,7 @@ class OLE
break; break;
default: default:
continue; break;
} }
fseek($fh, 1, SEEK_CUR); fseek($fh, 1, SEEK_CUR);
$pps->Type = $type; $pps->Type = $type;