alex
/
PhpSpreadsheet
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Eliminate unnecessary version checks

This commit is contained in:
Mark Baker 2013-06-16 10:26:16 +01:00
parent 4d92e77d00
commit 8f7db244de
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Classes/PHPExcel/Shared/OLE/ChainedBlockStream.php
View File

@ -161,14 +161,15 @@ class PHPExcel_Shared_OLE_ChainedBlockStream
*/
public function stream_eof()
{
$eof = $this->pos >= strlen($this->data);
// Workaround for bug in PHP 5.0.x: http://bugs.php.net/27508
if (version_compare(PHP_VERSION, '5.0', '>=') &&
version_compare(PHP_VERSION, '5.1', '<')) {
$eof = !$eof;
}
return $eof;
// As we don't support below 5.2 anymore, this is simply redundancy and overhead
// $eof = $this->pos >= strlen($this->data);
// // Workaround for bug in PHP 5.0.x: http://bugs.php.net/27508
// if (version_compare(PHP_VERSION, '5.0', '>=') &&
// version_compare(PHP_VERSION, '5.1', '<')) {
// $eof = !$eof;
// }
// return $eof;
return $this->pos >= strlen($this->data);
}
/**