alex
/
PhpSpreadsheet
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix return type docblock for the Cells::get() 

PHPStorm inspections and PHPStan display an incorrect hint or
error if the special type `null` is not specified.

Closes #1398
This commit is contained in:
Adrien Crivelli 2020-05-17 19:42:28 +09:00
parent 15bd764a08
commit 8eaceb0f92
No known key found for this signature in database
GPG Key ID: B182FD79DC6DE92E
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
### Fixed ### Fixed
- Fix Chart samples by updating chart parameter from 0 to DataSeries::EMPTY_AS_GAP [#1448](https://github.com/PHPOffice/PhpSpreadsheet/pull/1448) - Fix Chart samples by updating chart parameter from 0 to DataSeries::EMPTY_AS_GAP [#1448](https://github.com/PHPOffice/PhpSpreadsheet/pull/1448)
- Fix return type in docblock for the Cells::get() [#1398](https://github.com/PHPOffice/PhpSpreadsheet/pull/1398)
### Changed ### Changed

2
src/PhpSpreadsheet/Collection/Cells.php
View File

@ -426,7 +426,7 @@ class Cells
* *
* @param string $pCoord Coordinate of the cell * @param string $pCoord Coordinate of the cell
* *
* @return \PhpOffice\PhpSpreadsheet\Cell\Cell Cell that was found, or null if not found * @return null|\PhpOffice\PhpSpreadsheet\Cell\Cell Cell that was found, or null if not found
*/ */
public function get($pCoord) public function get($pCoord)
{ {