From 874467d7c1df5107210cde38ec8a4dd504174099 Mon Sep 17 00:00:00 2001 From: MarkBaker Date: Sun, 14 Oct 2018 16:21:40 +0100 Subject: [PATCH] DomPDF doesn't yet support PHP 7.3.0, so suppress tests for that combination of version and library dependency --- tests/PhpSpreadsheetTests/Helper/SampleTest.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/PhpSpreadsheetTests/Helper/SampleTest.php b/tests/PhpSpreadsheetTests/Helper/SampleTest.php index be1f50c6..d67848ee 100644 --- a/tests/PhpSpreadsheetTests/Helper/SampleTest.php +++ b/tests/PhpSpreadsheetTests/Helper/SampleTest.php @@ -35,6 +35,12 @@ class SampleTest extends TestCase $skipped[] = 'Pdf/21_Pdf_TCPDF.php'; } + // DomPDF does not support PHP 7.3 + if (version_compare(PHP_VERSION, '7.3.0') >= 0) { + $skipped[] = 'Basic/26_Utf8.php'; + $skipped[] = 'Pdf/21_Pdf_Domdf.php'; + } + // Unfortunately some tests are too long be ran with code-coverage // analysis on Travis, so we need to exclude them global $argv;