From 60533a4f594acb57744ef76edfb89dfaace0cad4 Mon Sep 17 00:00:00 2001 From: Adrien Crivelli Date: Sun, 2 Oct 2016 09:28:00 +0900 Subject: [PATCH] Fix unit tests for WEEKDAY() In Excel the expected value was incorrect (but it would be different for LibreOffice) --- tests/PhpSpreadsheetTests/Calculation/DateTimeTest.php | 3 --- tests/data/Calculation/DateTime/WEEKDAY.php | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/PhpSpreadsheetTests/Calculation/DateTimeTest.php b/tests/PhpSpreadsheetTests/Calculation/DateTimeTest.php index 12c621f4..a88ec163 100644 --- a/tests/PhpSpreadsheetTests/Calculation/DateTimeTest.php +++ b/tests/PhpSpreadsheetTests/Calculation/DateTimeTest.php @@ -156,12 +156,9 @@ class DateTimeTest extends \PHPUnit_Framework_TestCase /** * @dataProvider providerWEEKDAY - * @group fail19 */ public function testWEEKDAY() { - $this->markTestIncomplete('TODO: This test should be fixed'); - $args = func_get_args(); $expectedResult = array_pop($args); $result = call_user_func_array([DateTime::class, 'DAYOFWEEK'], $args); diff --git a/tests/data/Calculation/DateTime/WEEKDAY.php b/tests/data/Calculation/DateTime/WEEKDAY.php index 4f1a1b75..1dfe7efb 100644 --- a/tests/data/Calculation/DateTime/WEEKDAY.php +++ b/tests/data/Calculation/DateTime/WEEKDAY.php @@ -92,7 +92,7 @@ return [ ], [ '1900-2-1', - 1, + 4, ], [ 38093,