alex
/
PhpSpreadsheet
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bugfix: (vitalyrepin) Pull Request 869 - c:max and c:min elements shall NOT be inside c:orientation elements

This commit is contained in:
MarkBaker 2016-03-31 23:26:45 +01:00
parent 727ab1ef34
commit 18a45ee7a1
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.txt
View File

@ -32,6 +32,7 @@ Planned for 1.9
- Feature: (MBaker) - Additional codepages - Feature: (MBaker) - Additional codepages
- Feature: (Tomino2112) Work Item GH-808 - MemoryDrawing not working in HTML writer - Feature: (Tomino2112) Work Item GH-808 - MemoryDrawing not working in HTML writer
- General: (rentalhost) Work Item GH-575 - Excel 2007 Reader freezes because of conditional formatting - General: (rentalhost) Work Item GH-575 - Excel 2007 Reader freezes because of conditional formatting
- Bugfix: (vitalyrepin) Pull Request 869 - c:max and c:min elements shall NOT be inside c:orientation elements
2015-04-30 (v1.8.1): 2015-04-30 (v1.8.1):

5
src/PhpSpreadsheet/Writer/Excel2007/Chart.php
View File

@ -549,8 +549,6 @@ class Chart extends WriterPart
} }
$objWriter->startElement('c:scaling'); $objWriter->startElement('c:scaling');
$objWriter->startElement('c:orientation');
$objWriter->writeAttribute('val', $xAxis->getAxisOptionsProperty('orientation'));
if (!is_null($xAxis->getAxisOptionsProperty('maximum'))) { if (!is_null($xAxis->getAxisOptionsProperty('maximum'))) {
$objWriter->startElement('c:max'); $objWriter->startElement('c:max');
@ -564,6 +562,9 @@ class Chart extends WriterPart
$objWriter->endElement(); $objWriter->endElement();
} }
$objWriter->startElement('c:orientation');
$objWriter->writeAttribute('val', $xAxis->getAxisOptionsProperty('orientation'));
$objWriter->endElement(); $objWriter->endElement();
$objWriter->endElement(); $objWriter->endElement();