alex
/
PhpSpreadsheet
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

- Create unit test (#944) 

- Add changelog entry for issue #700
This commit is contained in:
Michael Roth 2019-04-15 21:39:11 +02:00 committed by Mark Baker
parent ccebf0f288
commit 15abdf43ad
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
- Fix handling for escaped enclosures and new lines in CSV Separator Inference - Fix handling for escaped enclosures and new lines in CSV Separator Inference
- Fix MATCH an error was appearing when comparing strings against 0 (always true) - Fix MATCH an error was appearing when comparing strings against 0 (always true)
- Fix wrong calculation of highest column with specified row [#700](https://github.com/PHPOffice/PhpSpreadsheet/issues/700)
- Fix VLOOKUP - Fix VLOOKUP
- Fix return type hint - Fix return type hint

17
tests/PhpSpreadsheetTests/Collection/CellsTest.php
View File

@ -114,4 +114,21 @@ class CellsTest extends TestCase
$collection->add('A1', $cell); $collection->add('A1', $cell);
$collection->add('A2', $cell); $collection->add('A2', $cell);
} }
public function testGetHighestColumn()
{
$workbook = new Spreadsheet();
$sheet = $workbook->getActiveSheet();
$collection = $sheet->getCellCollection();
// check for empty sheet
$this->assertEquals('A', $collection->getHighestColumn());
$this->assertEquals('A', $collection->getHighestColumn(1));
// set a value and check again
$sheet->getCell('C4')->setValue(1);
$this->assertEquals('C', $collection->getHighestColumn());
$this->assertEquals('A', $collection->getHighestColumn(1));
$this->assertEquals('C', $collection->getHighestColumn(4));
}
} }