From 0a826fe9a6611b9cf3f503410e1a961328406c86 Mon Sep 17 00:00:00 2001 From: Mark Baker Date: Mon, 25 Oct 2010 09:42:34 +0000 Subject: [PATCH] General: Applied patch 6609 - Removes a unnecessary loop through each cell when applying conditional formatting to a range. git-svn-id: https://phpexcel.svn.codeplex.com/svn/trunk@62766 2327b42d-5241-43d6-9e2a-de5ac946f064 --- Classes/PHPExcel/Style.php | 4 +--- changelog.txt | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Classes/PHPExcel/Style.php b/Classes/PHPExcel/Style.php index 61ad53b2..badc3153 100644 --- a/Classes/PHPExcel/Style.php +++ b/Classes/PHPExcel/Style.php @@ -610,9 +610,7 @@ class PHPExcel_Style implements PHPExcel_IComparable */ public function setConditionalStyles($pValue = null) { if (is_array($pValue)) { - foreach (PHPExcel_Cell::extractAllCellReferencesInRange($this->getSelectedCells()) as $cellReference) { - $this->getActiveSheet()->setConditionalStyles($cellReference, $pValue); - } + $this->getActiveSheet()->setConditionalStyles($this->getSelectedCells(), $pValue); } return $this; } diff --git a/changelog.txt b/changelog.txt index 7c76474a..5d5e9016 100644 --- a/changelog.txt +++ b/changelog.txt @@ -52,6 +52,7 @@ Fixed in SVN: These leading characters are most commonly associated with number, currency or accounting (or occasionally fraction) formats - Bugfix: (MBaker) Workitem 14374 - BUG : Excel5 and setReadFilter ? - Bugfix: (MBaker) Workitem 14425 - Wrong exception message while deleting column +- General: (MBaker) Applied patch 6609 - Removes a unnecessary loop through each cell when applying conditional formatting to a range. - General: (MBaker) Applied patch 7169 - Removed spurious PHP end tags (?>)