PhpSpreadsheet/tests/PhpSpreadsheetTests/Reader/CsvTest.php

<?php

namespace PhpOffice\PhpSpreadsheetTests\Reader;

use PhpOffice\PhpSpreadsheet\Reader\Csv;
use PHPUnit\Framework\TestCase;

class CsvTest extends TestCase
{
    public function testDelimiterDetection()
    {
        $reader = new Csv();
        self::assertNull($reader->getDelimiter());

        $filename = __DIR__ . '/../../data/Reader/CSV/semicolon_separated.csv';
        $spreadsheet = $reader->load($filename);

        self::assertSame(';', $reader->getDelimiter(), 'should be able to infer the delimiter');

        $actual = $spreadsheet->getActiveSheet()->getCell('C2')->getValue();
        self::assertSame('25,5', $actual, 'should be able to retrieve values with commas');
    }
}
Removed double un-escaping when reading CSV Removed "unescape enclosure functionality", since the unescaping is already handled by fgetcsv, and performing the unescaping again would actually result int the text from the cell being read wrong. As an example try parsing the folowing CSV: ``` "<img alt="""" src=""http://example.com/image.jpg"" />" ``` With the additional unescaping it would have ended up as: ``` <img alt=" src="http://example.com/image.jpg" /> ``` instead of the correct: ``` <img alt="" src="http://example.com/image.jpg" /> ``` Fixes https://github.com/PHPOffice/PHPExcel/pull/1171 2017-04-03 02:52:35 +00:00			`<?php`

			`namespace PhpOffice\PhpSpreadsheetTests\Reader;`

Introduce identical functional tests across several formats 2017-12-17 07:34:40 +00:00			`use PhpOffice\PhpSpreadsheet\Reader\Csv;`
Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase (#271) Use the `PHPUnit\Framework\TestCase` notation instead of `PHPUnit_Framework_TestCase` while extending our TestCases. This will help us migrate to PHPUnit 6, that [no longer support snake case class names](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.0.md#changed-1). 2017-11-08 15:48:01 +00:00			`use PHPUnit\Framework\TestCase;`
Removed double un-escaping when reading CSV Removed "unescape enclosure functionality", since the unescaping is already handled by fgetcsv, and performing the unescaping again would actually result int the text from the cell being read wrong. As an example try parsing the folowing CSV: ``` "<img alt="""" src=""http://example.com/image.jpg"" />" ``` With the additional unescaping it would have ended up as: ``` <img alt=" src="http://example.com/image.jpg" /> ``` instead of the correct: ``` <img alt="" src="http://example.com/image.jpg" /> ``` Fixes https://github.com/PHPOffice/PHPExcel/pull/1171 2017-04-03 02:52:35 +00:00
Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase (#271) Use the `PHPUnit\Framework\TestCase` notation instead of `PHPUnit_Framework_TestCase` while extending our TestCases. This will help us migrate to PHPUnit 6, that [no longer support snake case class names](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.0.md#changed-1). 2017-11-08 15:48:01 +00:00			`class CsvTest extends TestCase`
Removed double un-escaping when reading CSV Removed "unescape enclosure functionality", since the unescaping is already handled by fgetcsv, and performing the unescaping again would actually result int the text from the cell being read wrong. As an example try parsing the folowing CSV: ``` "<img alt="""" src=""http://example.com/image.jpg"" />" ``` With the additional unescaping it would have ended up as: ``` <img alt=" src="http://example.com/image.jpg" /> ``` instead of the correct: ``` <img alt="" src="http://example.com/image.jpg" /> ``` Fixes https://github.com/PHPOffice/PHPExcel/pull/1171 2017-04-03 02:52:35 +00:00			`{`
Infer CSV delimiter if it hasn't been set explicitly Closes #141 2017-04-17 16:51:53 +00:00			`public function testDelimiterDetection()`
			`{`
Introduce identical functional tests across several formats 2017-12-17 07:34:40 +00:00			`$reader = new Csv();`
Use `self::assert()` instead of `$this->assert()` Because even if it doesn't make a difference in practice, it is technically more correct to call static methods statically. It also better advertise that those methods can be used from any context. 2017-09-20 05:55:42 +00:00			`self::assertNull($reader->getDelimiter());`
Infer CSV delimiter if it hasn't been set explicitly Closes #141 2017-04-17 16:51:53 +00:00
			`$filename = __DIR__ . '/../../data/Reader/CSV/semicolon_separated.csv';`
			`$spreadsheet = $reader->load($filename);`

Use `self::assert()` instead of `$this->assert()` Because even if it doesn't make a difference in practice, it is technically more correct to call static methods statically. It also better advertise that those methods can be used from any context. 2017-09-20 05:55:42 +00:00			`self::assertSame(';', $reader->getDelimiter(), 'should be able to infer the delimiter');`
Infer CSV delimiter if it hasn't been set explicitly Closes #141 2017-04-17 16:51:53 +00:00
			`$actual = $spreadsheet->getActiveSheet()->getCell('C2')->getValue();`
Use `self::assert()` instead of `$this->assert()` Because even if it doesn't make a difference in practice, it is technically more correct to call static methods statically. It also better advertise that those methods can be used from any context. 2017-09-20 05:55:42 +00:00			`self::assertSame('25,5', $actual, 'should be able to retrieve values with commas');`
Infer CSV delimiter if it hasn't been set explicitly Closes #141 2017-04-17 16:51:53 +00:00			`}`
Removed double un-escaping when reading CSV Removed "unescape enclosure functionality", since the unescaping is already handled by fgetcsv, and performing the unescaping again would actually result int the text from the cell being read wrong. As an example try parsing the folowing CSV: ``` "<img alt="""" src=""http://example.com/image.jpg"" />" ``` With the additional unescaping it would have ended up as: ``` <img alt=" src="http://example.com/image.jpg" /> ``` instead of the correct: ``` <img alt="" src="http://example.com/image.jpg" /> ``` Fixes https://github.com/PHPOffice/PHPExcel/pull/1171 2017-04-03 02:52:35 +00:00			`}`